Abstract:

This video features a code review of a C++ snake game created by a viewer using the Raylib library. The reviewer is initially astounded by the project's professionalism, which includes extensive Doxygen documentation, unit tests, a clean CMake build system that automatically fetches dependencies, and a detailed project management structure using Jira tickets for commits. However, despite this impressive "on paper" presentation, a deeper dive into the code reveals significant architectural flaws. The primary critique focuses on the main game loop, which is unnecessarily complicated by redundant nested while loops within each state-handling function. The reviewer demonstrates that removing these loops has no negative effect on the game's functionality. Further issues include confusing state management, "dodgy" one-shot logic placed inside loops, and a breakdown of the modular design where core game logic bleeds into the rendering module. The video concludes by challenging the audience to analyze the flawed code and propose architectural improvements.

Code Review of a Professional C++ Snake Game

• 00:00:02 A Surprisingly Professional Project: The reviewer is immediately impressed by a viewer's C++ snake game project due to its professional presentation, which includes a detailed README, Doxygen documentation, unit tests, and Kanban project management using Jira.
• 02:30 Industry-Standard, for Better or Worse: The project's 181 commits and detailed process management are highlighted as a realistic, if sometimes bureaucratic, example of how projects are managed in the software industry.
• 05:32 Gameplay and Initial Flaws: The game itself is a level-based version of snake with increasing difficulty. The reviewer notes some initial negatives: the game window is not resizable, and it lacks a custom application icon, which is surprising given the project's overall polish.
• 07:02 The First Hurdle: Build & Run Issues: The game did not run correctly out of the box. It failed to load assets due to an incorrect working directory setting in Visual Studio, a common problem the reviewer has seen in other projects.
• 08:26 Excellent Build System & Modular Design: The project is praised for its use of CMake, which automatically downloads dependencies like Raylib and the Catch2 testing framework. Its modular architecture, separating the code into core, render, and main libraries, is seen as good practice for demonstrating an understanding of scalable software design, even if it's overkill for a simple snake game.
• 13:13 Architectural Flaw: Redundant Game Loops: The central critique of the code is the use of unnecessary nested while loops inside each of the state-handling functions (e.g., handle_menu_state, handle_game_state). The reviewer proves they are redundant by commenting them out, showing the game still runs perfectly with a single main game loop.
• 17:28 Confusing Code Flow and Design: The architecture is further criticized for having repeated code (like begin_drawing) in each state function instead of the main loop. The logic for creating and resetting the game state is described as "dodgy" and hard to follow because it's a one-time event triggered inside a loop.
• 22:07 A Challenge to the Community: The video concludes by leaving the architectural problems as an exercise for the audience. Viewers are encouraged to analyze the main.cpp file, think of ways to improve it, and discuss their ideas on the reviewer's Discord server for a future follow-up video.